Implement Default for NodeHtmlBlock #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Default derive for NodeHtmlBlock so that it can be constructed even though one of its fields is hidden.
This is useful for when you are replacing a node in the AST by creating an HTML block in its place. Having
Defaultimplemented makes it so you can specify only the fields you care about and not have to know about the#[doc(hidden)]fields.I noticed that the other structs with hidden fields (other than
Ast) all implementDefault, so I thought I would add it forNodeHtmlBlocktoo.It is probably a good idea to add some constructors for
Astas well so that people can create that struct when needed (to add brand new nodes to the tree). I don't know what those constructors would be (don't know the code well enough), so I'll leave that up to you. :)