Added a constructor for AstNode #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
I added a constructor for AstNode so we don't have to go through 3 constructors every time just to create one.
The issue I'm addressing is that
AstNodeisNode<'a, RefCell<Ast>>which is three nested objects. That means to make one from aNodeValue, you have to use three constructors:Rather than just make a utility function in my code, I thought it would be better to just add a constructor so you can do
AstNode::from(value)instead.If/when this gets merged, could you release a new patch version of
comrak? Thanks as always! 😄 🎉Documentation Screenshot