Make node value fields public #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kivikakk merged 1 commit into kivikakk:main from emschwartz:main

May 20, 2022

Contributor

emschwartz commented May 18, 2022 •

edited

Loading

Resolves #215

Please double-check that the field descriptions are correct. I had a bit of a hard time figuring out what each of them do.


          Make all node value fields public

2cf104a

Owner

kivikakk commented May 20, 2022

Thank you! These all look correct (enough?!) to me. They're similarly undocumented upstream: https://github.com/commonmark/cmark/blob/8a023286198a7e408398e282f293e3b0baebb644/src/node.h#L16

kivikakk merged commit dc2d4b5 into kivikakk:main

kivikakk mentioned this pull request

Incorrect AST for lists #457

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet