Skip to content

Conversation

@tranzystorekk
Copy link
Contributor

Hi, hope this isn't too big for a first contribution 🙂

Should make the code a bit more readable with the Derive API.

Notes:

  • had to bump pest in Cargo.lock to resolve a dependency conflict
  • the extension flag now additionally accepts comma-delimited lists, e.g. -e strikethrough,table,footnotes
  • clap no longer adds author info by default, so I skipped it for now (adding it back is a bit involved)

@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Nov 13, 2022

Seems we should somehow disable clap for wasm: lambda-fairy/rust-errno#21 (comment), or at least the wrap_help feature

@kivikakk
Copy link
Owner

Thank you so much, this is perfect, and certainly not too big at all! Really clear changes and very easy to review. Massively appreciated! 🥰

@kivikakk kivikakk merged commit e9295ff into kivikakk:main Nov 14, 2022
@tranzystorekk tranzystorekk deleted the clap-v4 branch November 14, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants