Skip to content

Conversation

@digitalmoksha
Copy link
Collaborator

This aligns the footnote output with cmark-gfm. Relates to #259

@kivikakk
Copy link
Owner

kivikakk commented Jan 25, 2023

Hi @digitalmoksha — thanks so much for this, this is great.

The spec builds are failing, but that's only because the extensions.txt spec in our vendored cmark-gfm doesn't match the new output. I tried pulling in the current upstream for that part of the file, and it also doesn't quite work due to some remaining differences in footnote ID generation (and a parsing issue with footnotes like Hello[^"><script>alert(1)</script>], which are apparently supported!).

That's fine with me — I'll address it in a follow-up PR. This here is great.

@kivikakk kivikakk force-pushed the add-footnote-attributes branch from 43430ce to ca91cd0 Compare January 25, 2023 03:44
@kivikakk kivikakk force-pushed the add-footnote-attributes branch from f5ba798 to fd6ebe7 Compare January 25, 2023 04:51
@kivikakk kivikakk merged commit cb72f1b into kivikakk:main Jan 25, 2023
@digitalmoksha
Copy link
Collaborator Author

Thanks @kivikakk for getting this over the line 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants