add PartialEq and Eq derive for Ast and its components #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @kivikakk , I haven't made any code changes which can make the tests fail, and they seem to fail on current master as well. Can you help a little bit figuring out the issue? |
Owner
|
Hi again @YJDoc2, thanks so much for this! Not to worry, this is an expected failure. @digitalmoksha's latest PR at #319 gets CI green again. Your changes are all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #211
This adds PartialEq and Eq derive for Ast. As you had said you'd be happy to accept a PR on this, opening this. In case you have some other direction for this, feel free to update/close.