Skip to content

Conversation

@digitalmoksha
Copy link
Collaborator

Related to #296

cmark-gfm does not detect an autolink in [[http://example.com]]. However by default comrak was.

This PR implements the cmark-gfm behavior. It also introduces the option relaxed-autolinks to allow detection inside brackets, as many other markdown packages do.

@digitalmoksha
Copy link
Collaborator Author

@kivikakk I think this takes care of the issue. Have a look when you get some time.

smart: false,
default_info_string: Some("abc".to_string()),
relaxed_tasklist_matching: true,
relaxed_tasklist_matching: false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this because the other options/extensions are turned off, including the task list extension. So it seems like that's the correct state to start off with.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any value is fine; we don't check the output! The purpose of this file was to notice when the API changed shape in any way, so I'd notice before I made a semver-breaking release.

I'll rewrite these to use the builders in a moment; there's no point to this test as written, since non-exhaustive means the structs can't be made this way from outside the crate.

Copy link
Owner

@kivikakk kivikakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

smart: false,
default_info_string: Some("abc".to_string()),
relaxed_tasklist_matching: true,
relaxed_tasklist_matching: false,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any value is fine; we don't check the output! The purpose of this file was to notice when the API changed shape in any way, so I'd notice before I made a semver-breaking release.

I'll rewrite these to use the builders in a moment; there's no point to this test as written, since non-exhaustive means the structs can't be made this way from outside the crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants