-
-
Notifications
You must be signed in to change notification settings - Fork 170
Fix autolink detection inside wiki style link brackets #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to allow detecting autolinks inside backets
|
@kivikakk I think this takes care of the issue. Have a look when you get some time. |
| smart: false, | ||
| default_info_string: Some("abc".to_string()), | ||
| relaxed_tasklist_matching: true, | ||
| relaxed_tasklist_matching: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this because the other options/extensions are turned off, including the task list extension. So it seems like that's the correct state to start off with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any value is fine; we don't check the output! The purpose of this file was to notice when the API changed shape in any way, so I'd notice before I made a semver-breaking release.
I'll rewrite these to use the builders in a moment; there's no point to this test as written, since non-exhaustive means the structs can't be made this way from outside the crate.
kivikakk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
| smart: false, | ||
| default_info_string: Some("abc".to_string()), | ||
| relaxed_tasklist_matching: true, | ||
| relaxed_tasklist_matching: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any value is fine; we don't check the output! The purpose of this file was to notice when the API changed shape in any way, so I'd notice before I made a semver-breaking release.
I'll rewrite these to use the builders in a moment; there's no point to this test as written, since non-exhaustive means the structs can't be made this way from outside the crate.
Related to #296
cmark-gfmdoes not detect an autolink in[[http://example.com]]. However by defaultcomrakwas.This PR implements the
cmark-gfmbehavior. It also introduces the optionrelaxed-autolinksto allow detection inside brackets, as many other markdown packages do.