Support both upstream CommonMark and GFM's differences in the base spec. #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Run on Wed Jul 10 17:09:09 UTC 2024 |
We add `caseless` to do the folding. It matches upstream enough [^1], unlike e.g. ICU4X's `CaseMapper` (doesn't fold Eszett to "ss"), and also unlike ICU4X, it doesn't require us to bump our MSRV. 2/2 sgtm A separate `--gfm-quirks` CLI option is added since base tests fail if we just turn on all of GFM for them. The nice thing about `caseless` is that while its last release may be 6 years ago, it depends on unicode-normalization ^0.1, the latest of which is 5 months ago. It's also [very easy to read][caseless], so I'm all good with this. [^1] Not that straightforward: commonmark/commonmark-spec#695 [caseless]: https://github.com/unicode-rs/rust-caseless/blob/v0.2.1/src/lib.rs
Owner
Author
|
/run-bench |
Collaborator
|
Whoa, cool! 🚀 |
Collaborator
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329.
WIP; I think there's some CommonMark revisions to catch up on.This brings us to CommonMark 0.31.2.