Skip to content

Conversation

@nicoburns
Copy link
Contributor

Objective

Reduce compile time / binary size impact of Comrak for projects that are not otherwise using the regex crate.

Changes made

  • Replace use of regex in a doctest with a simple String::contains
  • Replace the usage of regex in anchorization code with unicode_categories crate which comrak already depends on.
  • Removes once_cell dependendency, as it was only being used to cache a Regex

Comrak also currently also pulls in regex as a build dependency of caseless. But I have also sent that crate a PR to remove it's usage.

Replace usage with `unicode_categories` crate which comrak already
depends on.
@kivikakk
Copy link
Owner

Wonderful. Thank you!

@kivikakk kivikakk merged commit 7c6b947 into kivikakk:main Dec 18, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants