Fix stack smashing by converting recursion to iteration #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this changes the traversal order slightly, processing all siblings before descending into children. This could affect cache behavior in subsequent passes, but looking at the benchmark I haven't found anything conclusive.
brson
changed the title
Owner
|
So good! ❤️ Thank you! |
Owner
|
btw, I figure this won't be super relevant since you're working off a fork, but a crate release would ever be helpful to y'all, please feel free to shout. |
Collaborator
Author
|
Thanks. It's probably worth putting this out as a point release so that crates.io and docs.rs can get it. |
Owner
|
👍 |
brson
pushed a commit
to brson/comrak
that referenced
this pull request
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to feed comrak input that causes it to run off the end of the stack, e.g., a long series of ">>>>" is a nested blockquote and will recurse deeply.
This eliminates all the recursion I could find.
Note that the change to postprocess_text_nodes actually changes the order nodes are visited, and in a way that could affect correctness and cache behavior. I benchmarked the change and couldn't see any conclusive difference in perf.