keep NUL byte in the AST, translate to U+FFFD on output. #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Run on Sun Nov 2 10:45:18 UTC 2025 |
kivikakk
force-pushed
the
push-wwkskvnvmwun
branch
from
8435939 to
fe1dbc1
Compare
kivikakk
force-pushed
the
push-wwkskvnvmwun
branch
from
fe1dbc1 to
c871f8c
Compare
kivikakk
commented
Nov 3, 2025
Comment on lines
-233
to
-235
| // XXX As an extra special case, NUL bytes are expanded to U+FFFD | ||
| // REPLACEMENT CHARACTER (UTF-8: EF BF BD) during the feed stage, so | ||
| // sourcepos sees three bytes (!). I might like to change this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the need for a lot of input bookkeeping, plus it's much nicer — an end-user could differentiate between a NUL or U+FFFD if they wanted to.