don't append a newline at EOF; handle it in the parser. #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the last input feed oddity. The reference implementation forces every parsed line to end in a newline, even if the last line does not. This is not for spec reasons; a line can be ended by the end of file:
This PR adjusts the parser to be capable of dealing with end-of-input instead of assuming a newline will always be present. There's also a fair bit of "actually deal with CR or CRLF instead of assuming it's always LF" added.