Clean up find_special_char logic for inlines #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamwhite
commented
Nov 15, 2025
| } | ||
|
|
||
| fn is_special_char(&self, value: u8) -> bool { | ||
| if value == b'^' && self.within_brackets { |
Contributor
Author
There was a problem hiding this comment.
If it is possible for this to be incorrect without also testing special_char_bytes, a test case for that would be good
Owner
There was a problem hiding this comment.
It'd very be surprising if it could! It would suggest it had to do something with options.parse.smart. I think it's fine to leave as-is.
kivikakk
approved these changes
Nov 15, 2025
Owner
kivikakk
left a comment
kivikakk
left a comment
There was a problem hiding this comment.
Nice, thank you! I'm going to condense that enumerate/find/map sequence into a position call. I imagine they'll compile to the same machine code either way!
| } | ||
|
|
||
| fn is_special_char(&self, value: u8) -> bool { | ||
| if value == b'^' && self.within_brackets { |
Owner
There was a problem hiding this comment.
It'd very be surprising if it could! It would suggest it had to do something with options.parse.smart. I think it's fine to leave as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in this function was getting a bit unwieldy, so it's tidied up in this change by separating the logic for what counts as a special char from how to find it. It also unnests the conditionals and removes the need to constantly index into the input array.