Remove some superlinear complexity #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make rtrim more idiomatic.
The unsafety is unfortunate but I don't see a safe tool in std for doing this quickly.
kivikakk
approved these changes
Jun 27, 2018
Owner
kivikakk
left a comment
kivikakk
left a comment
There was a problem hiding this comment.
LGTM. Unsafe code seems fairly foolproof. (famous last words.)
Collaborator
Author
|
Agh, |
Owner
|
Are you depending on an earlier version? I figure targeting current stable (now 1.27) is reasonable given Rust's stable backwards compatibility. |
Collaborator
Author
|
@kivikakk No I'm not, but comrak works with toolchains at least as far back as 1.23, and this doesn't seem worth breaking compatibility over. |
Collaborator
Author
|
Now it's using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
unescapeandltrimwere doing exponential work based on the number of matches in the input, by callingremoverepeatedly, thus re-copying the same tail of the vector.Surprisingly, I don't see a better safe tool for this than
rotate_leftoffhand, which is a recently-stabilized API (and still isn't really the right tool), so I wrote some unsafe code, and only tested it lightly.cc @SSJohns