Cleanup feed and a NUL replacement fix
#83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some additional test cases.
Collaborator
Author
|
I recognize I should upstream these test cases, though the NUL cases I think don't actually work with spec_tests.py and would need a custom test harness. |
Since feed is private having these public is useless. For the moment Parser is still public because pub functions in the private table submodule take Parser, a curious assymetry in Rust's visibility rules.
Owner
|
Nice cleanup! As for a custom test harness, this seems fine/likely to be accepted upstream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal here was to simplify
feedbut I ended up doing a few other things:\0and newlines in the first commit - these were missed in the test suite, and seem to pass in the reference implementation.Ast. Most were only read to deal with accounting from feed being called multiple times, and even then the further results not actually used meaningfully. The final one,start_line, is only read in one location, and removing it doesn't affect the test suite to my recollection, but messing with it isn't particularly relevant here.