Skip to content

Add SDL3 bootstrap (alongside SDL3, SDL3_ttf, SDL3_mixer, SDL3_image recipes) for Kivy 3.0.0 #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2025
Merged

Add SDL3 bootstrap (alongside SDL3, SDL3_ttf, SDL3_mixer, SDL3_image recipes) for Kivy 3.0.0 #3125

merged 2 commits into from
Apr 12, 2025

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Mar 16, 2025 •
edited
Loading

  • Adds sdl3 bootstrap (alongside sdl3, sdl3_ttf, sdl3_mixer, sdl3_image recipes)
  • Allow kivy recipe to build with sdl3 support (but keeps sdl2 support)
  • Allow android and pyjnius recipe to build with sdl3 support (but keeps sdl2 support)
  • ⚠️ Test updated recipes is failing for an obvious reason (uses sdl2 boostrap but tries to build sdl3 which is incompatible)

Similar to kivy/kivy-ios#961

@T-Dynamos T-Dynamos mentioned this pull request Mar 27, 2025
Draft
@misl6 misl6 changed the title [WIP] Add SDL3 bootstrap Add SDL3 bootstrap (and allow kivy to build with it) Apr 8, 2025
@misl6 misl6 changed the title Add SDL3 bootstrap (and allow kivy to build with it) Add SDL3 bootstrap (alongside SDL3, SDL3_ttf, SDL3_mixer, SDL3_image recipes) for Kivy 3.0.0 Apr 8, 2025
@misl6 misl6 requested a review from AndreMiras April 8, 2025 19:20
AndreMiras
AndreMiras previously approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work again 👏
Made some minor suggestions, but nothing blocking, feel free to address in some follow up or never.
Thanks for the hard work, I can't wait to see it merged

@misl6 misl6 force-pushed the sdl3 branch 2 times, most recently from abb0b26 to 8251488 Compare April 10, 2025 20:33
AndreMiras
AndreMiras approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat and thanks for addressing/commenting on all comments even though none were critical.
Still looks good for me, I can't wait to see it merged

@misl6 misl6 merged commit 58d148b into kivy:develop Apr 12, 2025
21 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
python3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misl6 @AndreMiras @kuzeyron