Add check for 'none' response #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 13, 2025 13:19
…al None responses
…zation and add a check for 5xx error handling
… instead of existence
…zation with more detailed error messages and add a check for empty 500.txt files
…nization with more detailed error messages
…ns for better readability and maintainability
ChristianGeie
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that the request() function does not return a response object in the event of an error (e.g., after MaxRetryError), but rather None.
However, the code always calls
.textor.contenton the return object, which leads toAttributeError: ‘NoneType’ object has no attribute ‘text’.Fix:
Always return a response-like object in the request() function, even in the event of an error.
AND check in the calling code whether the result is None before using .text or .content.