Skip to content

Fix CD process for macOS #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Fix CD process for macOS #1054

merged 1 commit into from
Dec 15, 2024

Conversation

BPerlakiH
Copy link
Collaborator

Trying to fix the CD process for macOS, applying the same solution as in:
https://github.com/kiwix/kiwix-apple/pull/1046/files

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.02%. Comparing base (c3bbd3e) to head (4da36b7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   36.02%   36.02%           
=======================================
  Files         127      127           
  Lines        7461     7461           
=======================================
  Hits         2688     2688           
  Misses       4773     4773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Contributor

@BPerlakiH Not sure which problem it foxes, but let me know when this is OK your side

@BPerlakiH
Copy link
Collaborator Author

@BPerlakiH Not sure which problem it foxes, but let me know when this is OK your side

@kelson42 The release CD builds are failing for macOS, so we probably need the same solution we did for the CI builds.

@BPerlakiH
Copy link
Collaborator Author

I think it is good to be merged now.

@kelson42 kelson42 merged commit 868c1db into main Dec 15, 2024
4 checks passed
@kelson42 kelson42 deleted the fix-cd-process branch December 15, 2024 15:59
@kelson42 kelson42 added this to the 3.7.0 milestone Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants