Skip to content

Fix localisation, remove debugPrint statement #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1086

@BPerlakiH BPerlakiH force-pushed the 1086-fix-donation-translations branch from 32fba99 to 37100cd Compare January 21, 2025 20:23
@BPerlakiH BPerlakiH changed the title Fix localisation, remove debugPrint statement Fix localisation, remove debugPrint statement, patch 3.7.2 Jan 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.21%. Comparing base (d2c9f14) to head (be11aef).

Files with missing lines Patch % Lines
Views/Payment/CustomAmount.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1087       +/-   ##
===========================================
+ Coverage   23.92%   37.21%   +13.29%     
===========================================
  Files         124      129        +5     
  Lines        7018     7542      +524     
===========================================
+ Hits         1679     2807     +1128     
+ Misses       5339     4735      -604     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rgaudin
rgaudin previously approved these changes Jan 22, 2025
@kelson42
Copy link
Contributor

@BPerlakiH Actually we can not really make a patch release, so we will have to release 3.8.0 with only a few fixes.

@BPerlakiH BPerlakiH changed the title Fix localisation, remove debugPrint statement, patch 3.7.2 Fix localisation, remove debugPrint statement Jan 22, 2025
@BPerlakiH
Copy link
Collaborator Author

@kelson42, no problem, I have reverted the project file to be 3.8.0

@kelson42 kelson42 merged commit 0712e69 into main Jan 23, 2025
7 checks passed
@kelson42 kelson42 deleted the 1086-fix-donation-translations branch January 23, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing string in 3.7.1 donation button
4 participants