Skip to content

Fix new ZIM files page search result updates #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1093

The issue:

Formerly if we switched to another application on macOS, or to another tab on iPhone (or iPad split screen), the search field preserved the typed in value, but the filter would no longer apply.
Similarly if the languages selected changed, the filter would not re-apply on macOS.

Solution:

Use computed predicate for each view update, this way the filter properly re-applies.

Behaviour after:

ipad_after.mov
mac_os_after.mov

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.80%. Comparing base (10fd670) to head (ad5ea31).

Files with missing lines Patch % Lines
Views/Library/ZimFilesNew.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   36.78%   35.80%   -0.99%     
==========================================
  Files         132      132              
  Lines        7630     7628       -2     
==========================================
- Hits         2807     2731      -76     
- Misses       4823     4897      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit d2cda4f into main Jan 26, 2025
7 checks passed
@kelson42 kelson42 deleted the 1093-updating-new-zims branch January 26, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing new content
3 participants