Fix new ZIM files page search result updates #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1093
The issue:
Formerly if we switched to another application on macOS, or to another tab on iPhone (or iPad split screen), the search field preserved the typed in value, but the filter would no longer apply.
Similarly if the languages selected changed, the filter would not re-apply on macOS.
Solution:
Use computed predicate for each view update, this way the filter properly re-applies.
Behaviour after:
ipad_after.mov
mac_os_after.mov