-
Notifications
You must be signed in to change notification settings - Fork 29
refactor: change use php_brotli_context in brotli_uncompress() #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe decoder creation process in the Brotli extension was refactored by introducing a new function that accepts an error-handling parameter, consolidating decoder initialization and parameter setting. Existing functions were updated to use the new context-based decoder management, and error reporting was made more flexible and consistent. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant BrotliContext
participant Decoder
Caller->>BrotliContext: php_brotli_context_create_decoder_ex(ctx, fail)
BrotliContext->>Decoder: Create and configure decoder
alt Decoder creation fails
BrotliContext->>Caller: Emit warning (format depends on fail), return FAILURE
else Decoder creation succeeds
BrotliContext->>Caller: Return SUCCESS
end
Caller->>BrotliContext: Use context for decompression (brotli_uncompress, etc.)
BrotliContext->>Decoder: Stream decompression
Caller->>BrotliContext: Close context (cleanup)
Possibly related PRs
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings
brotli.c (1)
⏰ Context from checks skipped due to timeout of 90000ms (9)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary by CodeRabbit
Refactor
Bug Fixes