Add/version constants

[kjdev]

Summary by CodeRabbit

• New Features
  • Introduced two new constants, BROTLI_VERSION_NUMBER and BROTLI_VERSION_TEXT, providing access to the Brotli library version as an integer and a human-readable string.
• Documentation
  • Updated extension stubs to include the newly added version constants.

[coderabbitai]

Walkthrough

Two new constants, BROTLI_VERSION_NUMBER (integer) and BROTLI_VERSION_TEXT (string), are registered in the Brotli extension for version reporting. The module info output now uses these constants. The stub file is updated to declare the new constants. The configuration script and a header comment related to version macros are cleaned up.

Changes

File(s)	Change Summary
brotli.c	Registers BROTLI_VERSION_NUMBER and BROTLI_VERSION_TEXT constants; updates module info to use them.
brotli.stub.php	Declares new global constants: BROTLI_VERSION_TEXT (string) and BROTLI_VERSION_NUMBER (int).
config.m4	Removes macro definition for BROTLI_LIB_VERSION.
php_brotli.h	Removes a comment referencing BROTLI_LIB_VERSION.

Poem

In the land of Brotli, two constants appear,
A number and text, making versioning clear.
The config is tidied, old macros now gone,
While info displays what version you're on.
With stubs in sync, the code hops along—
A rabbit’s delight in a versioning song! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kjdev]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

brotli.c (1)

1312-1322: Register version constants in MINIT
The new block formats version_text and registers both BROTLI_VERSION_NUMBER and BROTLI_VERSION_TEXT. Please verify the bit-shift masks (>>24, >>12, &0xfff) match the Brotli API’s version-packing scheme. Consider using ZEND_STRL("BROTLI_VERSION_TEXT")/ZEND_STRL("BROTLI_VERSION_NUMBER") for consistency in constant registration.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c70736f and 1b26100.

📒 Files selected for processing (4)

• brotli.c (2 hunks)
• brotli.stub.php (1 hunks)
• config.m4 (0 hunks)
• php_brotli.h (0 hunks)

💤 Files with no reviewable changes (2)

• php_brotli.h
• config.m4

🔇 Additional comments (3)

brotli.stub.php (2)

66-70: Expose BROTLI_VERSION_TEXT in stubs
Declaration is correct with @var string and @cvalue.

---

72-76: Expose BROTLI_VERSION_NUMBER in stubs
Declaration is correct with @var int and @cvalue.

brotli.c (1)

1428-1431: Print library version in phpinfo
The MINFO update correctly fetches the BROTLI_VERSION_TEXT constant and displays it under “Library Version.”