Skip to content

Conversation

@jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Nov 20, 2025

Note this first requires Docker image to be published; see also docker-library/php#1630.

Summary by CodeRabbit

  • Chores
    • Expanded continuous integration testing coverage to include additional platform variants.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Walkthrough

Added two new PHP matrix variants (8.5-alpine and 8.5-zts-alpine) to the Linux CI workflow configuration, positioned before the 8.4-alpine entry. Expands tested PHP version and platform combinations without modifying workflow steps.

Changes

Cohort / File(s) Summary
Linux CI matrix expansion
.github/workflows/linux.yaml
Added 8.5-alpine and 8.5-zts-alpine PHP matrix variants to the CI workflow test matrix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

— Simple, homogeneous configuration addition with no logic changes or side effects.

Poem

🐰 More versions hop into the test array,
Alpine variants dance in CI's fray,
PHP 8.5 takes its graceful stride,
Through ZTS and standard, side by side! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Test on PHP 8.5' directly matches the main objective of adding PHP 8.5 matrix variants to the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03d07dc and 9119787.

📒 Files selected for processing (1)
  • .github/workflows/linux.yaml (1 hunks)
🔇 Additional comments (1)
.github/workflows/linux.yaml (1)

12-13: Matrix variant ordering and compatibility look good.

The new PHP 8.5 variants are positioned logically before 8.4, and the existing conditional logic in the workflow steps (checking for 'alpine', platform patterns, etc.) will work correctly with PHP 8.5 without any modifications needed.

@kjdev kjdev merged commit f08f4b7 into kjdev:master Nov 24, 2025
38 of 82 checks passed
@jnoordsij
Copy link
Contributor Author

Thanks for reviewing and finishing this!

@jnoordsij jnoordsij deleted the patch-2 branch November 25, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants