Skip to content

Dokholliday#19

Open
avaloki108 wants to merge 3 commits into
kleiton0x00:mainfrom
avaloki108:dokholliday
Open

Dokholliday#19
avaloki108 wants to merge 3 commits into
kleiton0x00:mainfrom
avaloki108:dokholliday

Conversation

@avaloki108

Copy link
Copy Markdown

No description provided.

@kleiton0x00

Copy link
Copy Markdown
Owner

This is an awesome PR. Will definitely review it once I finish my ongoing project(s).

Thank you for your contribution!

@kleiton0x00

Copy link
Copy Markdown
Owner

I reviewed the PR and I really appreciate the effort you put into this!

While the features you've introduced are impressive, I've encountered a few concerns. Unfortunately, the current implementation produces a significant number of false positives, particularly in the POST data payloads, which affects the precision of the tool.

The inclusion of ML and AI is an interesting approach, but it feels a bit overkill for this use case and isn't strictly necessary. In practice, the generated payloads are often invalid, which may be due to insufficient or inconsistent training data provided to the model.

On the other hand, the updated report format is a nice touch. However, since this tool is focused primarily on bug bounty/ security researchers, the CLI visuals are usually more than enough.

I won’t be closing this PR, as I don't want to shut the door on your contribution. I encourage you to refine the approach or explore ways to reduce the noise and improve the mentioned issues. Thanks again for your work!

@avaloki108

Copy link
Copy Markdown
Author

I totally didn't even mean for this to be seen by anyone!! my bad!!! I appreciate the kind words though. I have done a lot since then also.... I don't know. I'll share it when i get back to my computer at home. I wasn't going to share it with anyone.... hahaha.. I'm just obsessed with trying to find prototype pollution as of late...

@avaloki108

Copy link
Copy Markdown
Author

sorry.. I wasn't trying to change your tool... I was trying to save something of my own... my bad...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants