Skip to content

feat(web): fix courtcard hardcode values #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 5, 2023
Merged

feat(web): fix courtcard hardcode values #1007

merged 5 commits into from
Jul 5, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Jul 3, 2023 •
edited
Loading

closes #655

one thing worth noting is I didn't add the query types on the useJurorStakedCourts.ts file. How to generate them?

@netlify
Copy link

netlify bot commented Jul 3, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 8859f9a
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64a30ada1ad3c70008b61361
😎 Deploy Preview https://deploy-preview-1007--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 3, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 8859f9a
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/64a30adacb46bd0008c8e6c3
😎 Deploy Preview https://deploy-preview-1007--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alcercu
Copy link
Contributor

alcercu commented Jul 3, 2023

one thing worth noting is I didn't add the query types on the useJurorStakedCourts.ts file. How to generate them?

They are generated with the same yarn generate-gql command. You should be able to import it as in the other hooks.

@alcercu alcercu changed the base branch from dev to feat(5-7-demo)/merge-features July 5, 2023 11:49
alcercu
alcercu approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
28.5% 28.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alcercu alcercu merged commit a2b2753 into feat(5-7-demo)/merge-features Jul 5, 2023
@alcercu alcercu deleted the fix(web)/courtcard-hardcodes branch July 5, 2023 11:50
@jaybuidl jaybuidl added this to the alpha-1 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Feature🗿
Projects
None yet
Milestone
testnet-1
Development

Successfully merging this pull request may close these issues.

Hardcoded values: "10,000 PNK" and "1,000 PNK" on CourtCards.tsx
3 participants
@kemuru @alcercu @jaybuidl