Skip to content

feat(web): dynamic-values-in-cases-page #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 9, 2023
Merged

feat(web): dynamic-values-in-cases-page #1137

merged 4 commits into from
Aug 9, 2023

Conversation

nhestrompia
Copy link
Contributor

fixes #1084

alcercu
alcercu requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be way easier to use the counter entity, the id 0 will have the up-to-date counts 🙌🏻
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alcercu
alcercu approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 2a80888 into chore/testnet-and-devnet-deploy Aug 9, 2023
@jaybuidl jaybuidl added this to the alpha-testnet milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Feature🗿
Projects
None yet
Milestone
testnet-1
Development

Successfully merging this pull request may close these issues.
3 participants
@nhestrompia @alcercu @jaybuidl