Skip to content

fix(web): fix-cases-list-view-alignment #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

tractorss
Copy link
Contributor

@tractorss tractorss commented Jan 12, 2024

closes #1399

fixes the alignment of elements on cases list view


PR-Codex overview

Focus of this PR:

This PR focuses on improving the responsiveness and layout of the DisputeCard and CasesDisplay components.

Detailed summary:

  • Updated the width of DisputeCard component using a responsiveSize function.
  • Imported and used the responsiveSize function in PeriodBanner component to update the width.
  • Added flex: 1 to the DisputeInfo component to fill the available space.
  • Replaced flexbox with grid layout in RestOfFieldsContainer component.
  • Updated the layout of CasesListHeader component using grid layout.
  • Updated the layout of CasesData component using grid layout and added margin-right.
  • Updated the width of CaseTitle component using responsiveSize function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 5b5b233
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65a0e27a09c70b00087071e5
😎 Deploy Preview https://deploy-preview-1406--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Jan 12, 2024

Code Climate has analyzed commit 5b5b233 and detected 192 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 13
Duplication 26
Style 153

View more on Code Climate.

Copy link

@tractorss tractorss requested review from kemuru and alcercu January 12, 2024 07:01
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Jan 16, 2024
Merged via the queue into dev with commit 239869d Jan 16, 2024
@jaybuidl jaybuidl deleted the fix(web)/fix-cases-list-view-alignment branch January 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI bug: Case List view bugged/not aligned
4 participants