Skip to content

fix(web): fix-filter-stats-not-showing-correct-in-progress-cases #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

tractorss
Copy link
Contributor

@tractorss tractorss commented Jan 12, 2024

closes #1405

  • Fixes "In Progress" and "Closed" stats in Filter stats not showing correctly

numberClosedDisputes props in CaseDisplay , used in Dashboard/index.tsx was hardcoded to 0.
Updated that to use, totalResolvedDisputes from userQuery data


PR-Codex overview

Detailed summary

  • Added a new variable totalResolvedCases to store the total number of resolved disputes.
  • Updated the numberClosedDisputes prop in the Dashboard component to use the totalResolvedCases variable instead of a hardcoded value of 0.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit d562f21
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65a100ae8115a900088dfedd
😎 Deploy Preview https://deploy-preview-1407--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Copy link

codeclimate bot commented Jan 12, 2024

Code Climate has analyzed commit d562f21 and detected 193 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 13
Duplication 26
Style 154

View more on Code Climate.

@tractorss tractorss requested a review from alcercu January 12, 2024 09:05
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Jan 16, 2024
Merged via the queue into dev with commit a2d5653 Jan 16, 2024
@jaybuidl jaybuidl deleted the fix(web)/incorrect-progress-dispute-display branch January 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cases Filter Stats bug: shows "In Progress" when they should be "Closed"
3 participants