Skip to content

Fix(web)/evidence skeleton overflowing and info card loading UI #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tractorss
Copy link
Contributor

@tractorss tractorss commented Jan 12, 2024

closes #1397 #1398

  1. Added loading ui to "You were not drawn" Info Card

  2. Fixed evidence skleton loader overflowing

  • To reproduce 2. : open devtools in browser and set viewport width to a high value (> 2000px)
  • Reason: width of loader was set to 76vw, breaking the width
  • Fix: Added a wrapper around loader, since percentages dont work with Skeleton Loader

PR-Codex overview

Detailed summary

  • Changed the styling of StyledSkeletonEvidenceCard to StyledSkeletonEvidenceContainer in StyledSkeleton.tsx.
  • Added a Skeleton component to the SkeletonEvidenceCard in StyledSkeleton.tsx.
  • Imported Skeleton component in index.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit a48449f
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65a11e2a681b9a0008224ad9
😎 Deploy Preview https://deploy-preview-1408--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Jan 12, 2024

Code Climate has analyzed commit a48449f and detected 192 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 13
Duplication 26
Style 153

View more on Code Climate.

Copy link

@tractorss tractorss requested a review from alcercu January 12, 2024 11:12
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Jan 16, 2024
Merged via the queue into dev with commit a536cec Jan 16, 2024
@jaybuidl jaybuidl deleted the fix(web)/evidence-skeleton-overflowing-and-info-card-loading-ui branch January 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evidence loading skeleton is too big
3 participants