-
Notifications
You must be signed in to change notification settings - Fork 49
Fixes appeal tab issues #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes appeal tab issues #1420
Conversation
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The sum of funds must reach 100%. If it's not fully funded in time the option fully funded at{" "} | ||
<small>stage 1</small> is declared the winner of the case.{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly inaccurate, for the current implementation of DisputeKitClassic
the sum of funds is not considered, the only condition to make an appeal go through is to completely fund two options. So I would write something like this:
If the current winner is not fully funded in time, the option funded during the previous stage will be declared as the final winner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Code Climate has analyzed commit a6beea5 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
closes #1414 , closes #1416
Issues fixed by this PR :
PR-Codex overview
This PR focuses on refactoring the appeal feature in the CaseDetails page. It includes the following changes:
useLoserSideCountdownContext
hook touseCountdownContext
and addeduseWinnerSideCountdown
hook.StageOneExplanation
andStageTwoExplanation
components.StageExplainer
component to handle different stages.Tabs
component to disable a tab based on certain conditions.Options
component to use theuseCountdownContext
hook.StageOne
component to use theuseCountdownContext
anduseFundingContext
hooks.StageTwo
component to use theuseCountdownContext
,useFundingContext
, anduseOptionsContext
hooks.ClassicAppealProvider
component to use theuseCountdownContext
hook and provide the countdown values.useClassicAppealContext
hook to export theuseCountdownContext
hook.useWinnerSideCountdown
hook.getDeadline
function in theuseClassicAppealContext
hook.Fund
component to use theuseAccount
,useBalance
, andusePublicClient
hooks.