Skip to content

fix(deps): replace dependency eslint-plugin-node with eslint-plugin-n ^14.0.0#1648

Open
renovate[bot] wants to merge 1 commit into
devfrom
renovate/eslint-plugin-node-replacement
Open

fix(deps): replace dependency eslint-plugin-node with eslint-plugin-n ^14.0.0#1648
renovate[bot] wants to merge 1 commit into
devfrom
renovate/eslint-plugin-node-replacement

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Jul 12, 2024

This PR contains the following updates:

Package Type Update Change
eslint-plugin-nodeeslint-plugin-n dependencies replacement ^11.1.0^14.0.0

⚠️ Renovate's replacement functionality does not currently wire in the release age for a package, so the Minimum Release Age checks can apply. You will need to manually validate the Minimum Release Age for these package(s).

This is a special PR that replaces eslint-plugin-node with the community suggested minimal stable replacement version.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • Between 12:00 AM and 03:59 AM (* 0-3 * * *)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added the dependencies Pull requests that update a dependency file label Jul 12, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 12, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e2d38e03-5e9a-45b4-a71c-9da6f4044662

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The ESLint configuration has been updated by removing the eslint-plugin-node dependency and adding eslint-plugin-n with version ^14.0.0. This change modifies the linting setup while keeping the overall dependency structure intact.

Changes

File Change Summary
eslint-config/package.json Removed eslint-plugin-node version ^11.1.0, added eslint-plugin-n version ^14.0.0.

Poem

In the garden of code, hops a rabbit so spry,
With plugins anew, we’ll reach for the sky!
A change in the air, fresh linting to see,
With eslint-plugin-n, we’ll dance with glee!
So hop, little coder, let’s clean up the mess,
Together we thrive, in code we’ll progress! 🐇✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renovate/eslint-plugin-node-replacement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2024

Deploy Preview for kleros-v2-university failed. Why did it fail? →

Name Link
🔨 Latest commit 7fcbdd1
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-university/deploys/68c9a43bfe231d00091d166e

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2024

Deploy Preview for kleros-v2-neo failed. Why did it fail? →

Name Link
🔨 Latest commit 0cc283e
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-neo/deploys/69d938619da3880008b2a3a5

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2024

Deploy Preview for kleros-v2-testnet ready!

Name Link
🔨 Latest commit 0cc283e
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-testnet/deploys/69d938618a274b0007afddb2
😎 Deploy Preview https://deploy-preview-1648--kleros-v2-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch 5 times, most recently from f14dcda to 433dcb8 Compare July 22, 2024 11:37
@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch 5 times, most recently from 0546eb2 to a1cd487 Compare July 29, 2024 16:49
@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch 2 times, most recently from 824fc17 to e7a92f0 Compare August 7, 2024 10:32
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
eslint-config/package.json (1)

14-14: Ensure proper configuration of eslint-plugin-n in ESLint configuration files.

The replacement of eslint-plugin-node with eslint-plugin-n version ^14.0.0 is present in eslint-config/package.json and yarn.lock. However, there is no evidence of eslint-plugin-n being configured in any ESLint configuration files. Please verify and update the ESLint configuration files to include eslint-plugin-n.

  • eslint-config/package.json
  • yarn.lock
Analysis chain

LGTM! Verify the installation and configuration of eslint-plugin-n.

The replacement of eslint-plugin-node with eslint-plugin-n version ^14.0.0 is approved.

Ensure that the new plugin is correctly installed and configured to maintain linting capabilities.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the installation and configuration of `eslint-plugin-n`.

# Test: Check if `eslint-plugin-n` is installed. Expect: The package should be listed.
npm list eslint-plugin-n

# Test: Check if `.eslintrc.js` contains the configuration for `eslint-plugin-n`. Expect: The configuration should be present.
rg --type js 'eslint-plugin-n' .eslintrc.js

Length of output: 194


Script:

#!/bin/bash
# Description: Search for ESLint configuration files and check for `eslint-plugin-n` configuration.

# Find all potential ESLint configuration files in the repository.
fd -e js -e json -e yaml -e yml -e cjs -e mjs -e ts -e coffee --regex 'eslint'

# Check if any of these files contain the configuration for `eslint-plugin-n`.
fd -e js -e json -e yaml -e yml -e cjs -e mjs -e ts -e coffee --regex 'eslint' --exec rg 'eslint-plugin-n' {}

Length of output: 188


Script:

#!/bin/bash
# Description: Search all files in the repository for `eslint-plugin-n` configuration.

# Check if any files in the repository contain the configuration for `eslint-plugin-n`.
rg 'eslint-plugin-n'

Length of output: 262

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d1fef37 and e7a92f0.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • eslint-config/package.json (1 hunks)

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 7, 2024
@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch 2 times, most recently from 6441627 to 444d4c2 Compare August 7, 2024 11:30
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e7a92f0 and 444d4c2.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • eslint-config/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • eslint-config/package.json

@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch from 444d4c2 to f40ae42 Compare August 7, 2024 12:04
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 444d4c2 and f40ae42.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • eslint-config/package.json

@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch from f40ae42 to e3392d8 Compare August 7, 2024 16:33
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f40ae42 and e3392d8.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • eslint-config/package.json

@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch from e3392d8 to 2fffb97 Compare August 7, 2024 17:18
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e3392d8 and 2fffb97.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • eslint-config/package.json

@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch from 2fffb97 to 04a6b46 Compare August 9, 2024 14:08
@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch 19 times, most recently from 50e708e to a8b9169 Compare November 11, 2024 09:06
@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch 3 times, most recently from a3cb9c7 to c9c92bd Compare November 19, 2024 17:32
@renovate renovate Bot force-pushed the renovate/eslint-plugin-node-replacement branch 2 times, most recently from 211971e to d57c91a Compare November 27, 2024 12:24
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
eslint-config/package.json (1)

14-14: Dependency Update: Replacing eslint-plugin-node with eslint-plugin-n

The new dependency "eslint-plugin-n": "^14.0.0" has been added in place of the old eslint-plugin-node dependency. Please ensure that any ESLint configuration files (for example, .eslintrc.js) are updated accordingly to reflect the usage and rule adjustments of the new plugin.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 99bc89e and 08f9692.

📒 Files selected for processing (1)
  • eslint-config/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: contracts-testing
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Mend Security Check

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 5ca99b7 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 5, 2025

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant