feat: ens in evidence #2027
feat: ens in evidence #2027
Conversation
✅ Deploy Preview for kleros-v2-testnet-devtools ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kleros-v2-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe EvidenceCard component is updated to replace the identicon and shortened address display with a new styled internal link wrapping the JurorTitle component. Related styled components and unused imports are removed, and layout styling for sender information is revised to use flexbox with responsive adjustments. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EvidenceCard
participant JurorTitle
User->>EvidenceCard: Render EvidenceCard
EvidenceCard->>JurorTitle: Render JurorTitle inside StyledJurorInternalLink
JurorTitle-->>EvidenceCard: Juror identity displayed
EvidenceCard-->>User: Show updated sender info layout
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
web/src/components/EvidenceCard.tsx (1)
23-23: Verify path correctness for JurorTitle import
JurorTitleis now imported through a relatively deep path (pages/Home/TopJurors/JurorCard/JurorTitle).
If a barrel export exists (e.g.pages/Home/TopJurors/index.ts) consider re-exportingJurorTitlethere to avoid brittle deep-path imports and to reduce the likelihood of future breakage when directories are reorganised.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/src/components/EvidenceCard.tsx(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: Redirect rules - kleros-v2-testnet
- GitHub Check: Redirect rules - kleros-v2-neo
- GitHub Check: Redirect rules - kleros-v2-testnet
- GitHub Check: Redirect rules - kleros-v2-testnet-devtools
- GitHub Check: Header rules - kleros-v2-testnet
- GitHub Check: Header rules - kleros-v2-testnet
- GitHub Check: Header rules - kleros-v2-neo
- GitHub Check: Header rules - kleros-v2-testnet-devtools
- GitHub Check: Pages changed - kleros-v2-testnet
- GitHub Check: Pages changed - kleros-v2-testnet
- GitHub Check: Pages changed - kleros-v2-neo
- GitHub Check: Pages changed - kleros-v2-testnet-devtools
- GitHub Check: SonarCloud
- GitHub Check: contracts-testing
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
web/src/components/EvidenceCard.tsx (2)
101-104: Portrait → landscape layout switch looks goodSwitching
BottomLeftContentto a flex layout withgapsimplifies spacing and removes the old descendant selector hack – nice cleanup.
238-240: Profile link contains hard-coded “1”
/profile/1/desc/all?address=${sender}hard-codes “1”. If this is intended to be the chain ID or page number, consider deriving it from router params / context so it doesn’t diverge across networks.-const profileLink = `/profile/1/desc/all?address=${sender}`; +const profileLink = `/profile/${chainId}/desc/all?address=${sender}`; // obtain chainId from context
❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →
|
|
Code Climate has analyzed commit 70b21f9 and detected 0 issues on this pull request. View more on Code Climate. |
|
PR-Codex overview
This PR focuses on refactoring the
EvidenceCardcomponent inEvidenceCard.tsx. It simplifies the layout and styling, removes unused imports, and updates the structure for displaying juror information.Detailed summary
IdenticonandshortenAddress.JurorTitle.BottomLeftContentto useflexlayout with a gap.AccountContainerand replaced it withStyledJurorInternalLinkusingJurorTitle.StyledJurorInternalLink.Summary by CodeRabbit