Skip to content

Clean-up post extraction from Kleros V2, support for Gnosis chain #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 27, 2023
Merged

Clean-up post extraction from Kleros V2, support for Gnosis chain #43

merged 16 commits into from
Jan 27, 2023

Conversation

adi274
Copy link
Contributor

@adi274 adi274 commented Nov 17, 2022

  • Fixes the naming (Home -> Sender, Foreign -> Receiver)
  • Rinkeby Testnet removal

@adi274 adi274 requested a review from jaybuidl November 17, 2022 06:57
@adi274 adi274 linked an issue Nov 17, 2022 that may be closed by this pull request
Clean-up post extraction from Kleros v2 #36
Closed
5 tasks
@adi274 adi274 changed the title fix: Clean-up post extraction from Kleros V2 fix: (WIP)Clean-up post extraction from Kleros V2 Nov 21, 2022
@jaybuidl jaybuidl added Type: Maintenance 🚧 Type: Toolchain ⚒️ Build tools configuration, CI/CD Package: Contracts Smart contracts Package: Relayer Subgraph Relayer Subgraph and removed Type: Toolchain ⚒️ Build tools configuration, CI/CD Package: Relayer Subgraph Relayer Subgraph labels Nov 28, 2022
jaybuidl
jaybuidl reviewed Jan 27, 2023
View reviewed changes
contracts/hardhat.config.ts
@@ -64,7 +64,7 @@ const config: HardhatUserConfig = {
saveDeployments: true,
tags: ["staging", "sender", "layer2"],
companionNetworks: {
receiver: "goerli",
receiver: "chiado",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm we'll need to find a better solution, that won't scale. Here the ArbiGoerli->Gerli deployment is certainly affected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's look for a better solution later in a separate branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it!

@jaybuidl jaybuidl marked this pull request as ready for review January 27, 2023 14:52
@jaybuidl jaybuidl changed the title fix: (WIP)Clean-up post extraction from Kleros V2 Clean-up post extraction from Kleros V2, support for Gnosis chain Jan 27, 2023
jaybuidl
jaybuidl previously approved these changes Jan 27, 2023
View reviewed changes
@jaybuidl jaybuidl force-pushed the fix-deployment-scripts branch from d13af8f to 75f9b56 Compare January 27, 2023 18:06
@jaybuidl jaybuidl merged commit 75f9b56 into master Jan 27, 2023
@jaybuidl jaybuidl deleted the fix-deployment-scripts branch January 27, 2023 18:10
@jaybuidl jaybuidl linked an issue Jan 27, 2023 that may be closed by this pull request
New bridge from Arbitrum Goerli to Chiado: happy path #57
Closed
3 tasks
jaybuidl added a commit that referenced this pull request Apr 29, 2023
@jaybuidl
fix: companion networks issues inherited from #62 #43
69b8942
@jaybuidl jaybuidl added this to the 0.2 - devnet to goerli milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaybuidl jaybuidl jaybuidl left review comments

Assignees

@adi274 adi274

Labels
Package: Contracts Smart contracts Type: Maintenance 🚧
Projects
None yet
Milestone
0.2 - devnet to goerli
Development

Successfully merging this pull request may close these issues.

New bridge from Arbitrum Goerli to Chiado: happy path Clean-up post extraction from Kleros v2
3 participants
@adi274 @shotaronowhere @jaybuidl