Skip to content

changes(footer): Added CNCF Sandbox information #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yashisrani
Copy link
Contributor

  • I added CNCF sandbox information in the footer section
Screenshot 2025-06-08 at 8 49 16 PM

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Jun 8, 2025

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit 0743b46
🔍 Latest deploy log https://app.netlify.com/projects/kmesh-net/deploys/6845aa4c834f4200085f64ca
😎 Deploy Preview https://deploy-preview-197--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yp969803
Copy link
Contributor

yp969803 commented Jun 8, 2025

Screenshot from 2025-06-09 02-59-02
fonts are too small

@yp969803
Copy link
Contributor

yp969803 commented Jun 8, 2025

footer is only needed in welcome page , not in other pages

@yp969803
Copy link
Contributor

yp969803 commented Jun 8, 2025

@Jayesh0167 please review

@yashisrani
Copy link
Contributor Author

@jayesh9747 sir, please review this pr

@jayesh9747
Copy link
Contributor

@yashisrani we need simple footer which is already there. you can close your PR. thank you.

@yp969803
Copy link
Contributor

@jayesh9747 it is good if we provide cncf sandbox information in the footer, i think the pr is needed

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the logo only on welcome page, but other pages it is not rendered

@yp969803
Copy link
Contributor

@yashisrani i think we can place the sandbox info on welcome page, not on footer

@yp969803
Copy link
Contributor

something like this
Screenshot from 2025-06-25 22-37-04
as cilium is doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants