-
Notifications
You must be signed in to change notification settings - Fork 41
changes(footer): Added CNCF Sandbox information #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
yashisrani
commented
Jun 8, 2025
- I added CNCF sandbox information in the footer section

Signed-off-by: Yash Israni <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
footer is only needed in welcome page , not in other pages |
@Jayesh0167 please review |
@jayesh9747 sir, please review this pr |
@yashisrani we need simple footer which is already there. you can close your PR. thank you. |
@jayesh9747 it is good if we provide cncf sandbox information in the footer, i think the pr is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the logo only on welcome page, but other pages it is not rendered
@yashisrani i think we can place the sandbox info on welcome page, not on footer |