Adding github action to test downstream repos. #1653

n3wscott · 2020-08-27T18:01:21Z

Integrate the knative-sandbox/downstream-test-go action that takes two repos that are checked out and upgrades the downstream with an upstream module, and then runs the standard knative repo update-codegen and runs the unit tests.

This PR makes it an FYI that any future PR will test on the following:

Serving
Eventing
Eventing Contrib
Sample Controller
Sample Source

n3wscott · 2020-08-27T20:10:25Z

/hold

going to roll this into a custom github action

n3wscott · 2020-08-31T22:25:01Z

/unhold

This is ready.

vaikas · 2020-08-31T23:00:53Z

Looks like there was a data race in serving? Can't figure out how to properly cut&paste :)

Goroutine 12 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.15.0/x64/src/testing/testing.go:1159 +0x796
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.15.0/x64/src/testing/testing.go:1430 +0xa6
  testing.tRunner()
      /opt/hostedtoolcache/go/1.15.0/x64/src/testing/testing.go:1108 +0x202
  testing.runTests()
      /opt/hostedtoolcache/go/1.15.0/x64/src/testing/testing.go:1428 +0x5aa
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.15.0/x64/src/testing/testing.go:1338 +0x4eb
  main.main()
      _testmain.go:47 +0x236

vagababov · 2020-08-31T23:12:55Z

golang/go#40908

n3wscott · 2020-09-02T16:34:27Z

/retest

n3wscott · 2020-09-03T19:35:04Z

This is good to go. @mattmoor

mattmoor · 2020-09-03T23:07:00Z

.github/workflows/knative-downstream.yaml

+    name: Serving
+    strategy:
+      matrix:
+        go-version: [1.15.x]


mattmoor · 2020-09-03T23:07:13Z

.github/workflows/knative-downstream.yaml

+    name: Eventing
+    strategy:
+      matrix:
+        go-version: [1.15.x]


…integration

…tests

n3wscott · 2020-09-11T23:22:38Z

/retest

mattmoor · 2020-09-11T23:23:36Z

.github/workflows/knative-verify.yaml

@@ -53,7 +53,6 @@ jobs:
    - name: Check out code onto GOPATH
      uses: actions/checkout@v2
      with:
-        fetch-depth: 1


why is this changing

1 is default, ah well it will get rolled back. This PR is older than .github repo :D

mattmoor · 2020-09-11T23:52:42Z

/lgtm
/approve

knative-prow-robot · 2020-09-11T23:52:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 27, 2020

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 27, 2020

knative-prow-robot requested review from evankanderson and vaikas August 27, 2020 18:01

n3wscott mentioned this pull request Aug 27, 2020

Git Hub Action - downstream-test-go knative/community#242

Merged

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020

n3wscott force-pushed the test_downstream branch 3 times, most recently from 1f37f51 to efadcd6 Compare August 31, 2020 20:38

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2020

n3wscott force-pushed the test_downstream branch from 50ac611 to ec74e63 Compare August 31, 2020 22:06

n3wscott changed the title ~~looking at what a github action would look like to test a downstream integration.~~ Adding github action to test downstream repos. Aug 31, 2020

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020

mattmoor reviewed Sep 3, 2020

View reviewed changes

.github/workflows/knative-downstream.yaml Outdated

name: Serving

strategy:

matrix:

go-version: [1.15.x]

Copy link

Member

mattmoor Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.14.x

mattmoor reviewed Sep 3, 2020

View reviewed changes

.github/workflows/knative-downstream.yaml Outdated

name: Eventing

strategy:

matrix:

go-version: [1.15.x]

Copy link

Member

mattmoor Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.14.x

Scott Nichols added 8 commits September 11, 2020 16:05

looking at what a github action would look like to test a downstream …

ffa8a28

…integration

sample controller has no real tests, so this was a bad test.

ff83de2

use the downstream-test-go action

12ef6c1

checkout happens in the steps, the action merges the two and run the …

cf8373b

…tests

adding serving.

7400d53

adding eventing-contrib and the samples.

3f886d8

select major api only.

2e763d7

revert semver change

b3c8e45

Scott Nichols added 2 commits September 11, 2020 16:05

only run the downstream tests on PRs

80c3daa

go 1.15

8b883bb

n3wscott force-pushed the test_downstream branch from 8a6492e to 8b883bb Compare September 11, 2020 23:06

mattmoor reviewed Sep 11, 2020

View reviewed changes

knative-prow-robot assigned mattmoor Sep 11, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020

knative-prow-robot merged commit de640e8 into knative:master Sep 11, 2020

n3wscott mentioned this pull request Sep 13, 2020

Tighter feedback loop with knative-sandbox/net-contour projectcontour/contour#2863

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding github action to test downstream repos. #1653

Adding github action to test downstream repos. #1653

Uh oh!

n3wscott commented Aug 27, 2020 •

edited

Loading

Uh oh!

n3wscott commented Aug 27, 2020

Uh oh!

n3wscott commented Aug 31, 2020

Uh oh!

vaikas commented Aug 31, 2020 •

edited

Loading

Uh oh!

vagababov commented Aug 31, 2020

Uh oh!

n3wscott commented Sep 2, 2020

Uh oh!

n3wscott commented Sep 3, 2020

Uh oh!

mattmoor Sep 3, 2020

Uh oh!

mattmoor Sep 3, 2020

Uh oh!

n3wscott commented Sep 11, 2020

Uh oh!

mattmoor Sep 11, 2020

Uh oh!

n3wscott Sep 11, 2020

Uh oh!

mattmoor commented Sep 11, 2020

Uh oh!

knative-prow-robot commented Sep 11, 2020

Uh oh!

Uh oh!

Adding github action to test downstream repos. #1653

Adding github action to test downstream repos. #1653

Uh oh!

Conversation

n3wscott commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n3wscott commented Aug 27, 2020

Uh oh!

n3wscott commented Aug 31, 2020

Uh oh!

vaikas commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vagababov commented Aug 31, 2020

Uh oh!

n3wscott commented Sep 2, 2020

Uh oh!

n3wscott commented Sep 3, 2020

Uh oh!

mattmoor Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

mattmoor Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

n3wscott commented Sep 11, 2020

Uh oh!

mattmoor Sep 11, 2020

Choose a reason for hiding this comment

Uh oh!

n3wscott Sep 11, 2020

Choose a reason for hiding this comment

Uh oh!

mattmoor commented Sep 11, 2020

Uh oh!

knative-prow-robot commented Sep 11, 2020

Uh oh!

Uh oh!

n3wscott commented Aug 27, 2020 •

edited

Loading

vaikas commented Aug 31, 2020 •

edited

Loading