-
Notifications
You must be signed in to change notification settings - Fork 1.2k
drop unnecessary 'kn.activator.proxy' metric/span attribute #16045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16045 +/- ##
==========================================
+ Coverage 80.22% 80.30% +0.08%
==========================================
Files 214 214
Lines 16910 16908 -2
==========================================
+ Hits 13566 13578 +12
+ Misses 2984 2971 -13
+ Partials 360 359 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cali0707
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.19 |
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dprotaso: new pull request created: #16047 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I was trying to be smart when adding this attribute because I thought the 'tag' would appear in child spans and we could see filter traces that went through the activator. OTel doesn't work that way - it's just adding stuff to the current span (which is already associated with the activator service).
Also regarding metrics - you could use this a filter but it's not necessary since you filter the activator using the container/pod name.
/assign @Cali0707
cc @evankanderson