-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Drop probe tracing in queue-proxy #16048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cherry-pick release-1.19 |
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16048 +/- ##
==========================================
- Coverage 80.28% 80.16% -0.13%
==========================================
Files 214 214
Lines 16905 16888 -17
==========================================
- Hits 13572 13538 -34
- Misses 2972 2989 +17
Partials 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cali0707
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dprotaso: new pull request created: #16050 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I'm noticing when looking at the jaeger traces the queue probes (kubelet/activator) are pretty meaningless since they're not being parented to anything.
Also
otelhttpis not filtering them out since we're 'starting' the trace within the queue-proxy. This makes it internal./assign @Cali0707
/assign @evankanderson