Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Aug 29, 2025

I'm noticing when looking at the jaeger traces the queue probes (kubelet/activator) are pretty meaningless since they're not being parented to anything.

Also otelhttp is not filtering them out since we're 'starting' the trace within the queue-proxy. This makes it internal.

/assign @Cali0707
/assign @evankanderson

@knative-prow knative-prow bot requested review from dsimansk, gauron99 and skonto August 29, 2025 19:08
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2025
@dprotaso
Copy link
Member Author

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.16%. Comparing base (5832a44) to head (58430ed).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/queue/sharedmain/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16048      +/-   ##
==========================================
- Coverage   80.28%   80.16%   -0.13%     
==========================================
  Files         214      214              
  Lines       16905    16888      -17     
==========================================
- Hits        13572    13538      -34     
- Misses       2972     2989      +17     
  Partials      361      361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9632161 into knative:main Aug 29, 2025
67 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #16050

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso dprotaso deleted the drop-queue-probe-tracing branch August 29, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants