Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Sep 3, 2025

Feedback from Evan in knative/docs#6352

  • update queue proxy metric description
  • stats scraper stat should include namespace

/assign @evankanderson

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2025
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Sep 3, 2025

sorry - didn't run unit tests locally. Fixed now

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.18%. Comparing base (1fb2561) to head (f2d2a36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16062      +/-   ##
==========================================
+ Coverage   80.17%   80.18%   +0.01%     
==========================================
  Files         214      214              
  Lines       16892    16893       +1     
==========================================
+ Hits        13543    13546       +3     
+ Misses       2989     2986       -3     
- Partials      360      361       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evankanderson
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@knative-prow knative-prow bot merged commit a0e1543 into knative:main Sep 3, 2025
67 checks passed
@dprotaso dprotaso deleted the serving-metric-tweaks branch September 3, 2025 22:35
@dprotaso
Copy link
Member Author

dprotaso commented Sep 3, 2025

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #16063

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants