-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Serving Metric Tweaks #16062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serving Metric Tweaks #16062
Conversation
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
sorry - didn't run unit tests locally. Fixed now |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16062 +/- ##
==========================================
+ Coverage 80.17% 80.18% +0.01%
==========================================
Files 214 214
Lines 16892 16893 +1
==========================================
+ Hits 13543 13546 +3
+ Misses 2989 2986 -3
- Partials 360 361 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
/cherry-pick release-1.19 |
|
@dprotaso: new pull request created: #16063 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Feedback from Evan in knative/docs#6352
/assign @evankanderson