Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Sep 9, 2025

This reverts commit (#16037) 12777f6.

I've noticed the automatic dep bumps all failed with 'ProgressDeadlineExceeded=True-Message=Initial Scale was never reached`.

So there's something flakey about this change

Part of: #16036

@knative-prow knative-prow bot requested a review from dsimansk September 9, 2025 16:57
@knative-prow
Copy link

knative-prow bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from skonto September 9, 2025 16:57
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Sep 9, 2025

/assign @nader-ziada

@nader-ziada
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.09%. Comparing base (12777f6) to head (f18364a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16075      +/-   ##
==========================================
+ Coverage   80.01%   80.09%   +0.08%     
==========================================
  Files         214      214              
  Lines       16895    16877      -18     
==========================================
  Hits        13518    13518              
+ Misses       3011     2993      -18     
  Partials      366      366              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot merged commit 7a8c89b into knative:main Sep 9, 2025
72 checks passed
@nader-ziada
Copy link
Member

follow up here: #16078

@dprotaso dprotaso deleted the revert-pa-conditions branch September 15, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants