[release-1.18] Fix min-scale transition #16100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a previous revision should scale down when only the next revision is ready
knative-prow
bot
added
the
size/XL
Member
|
/lgtm I might see if there are other patches we might want to merge along with this one /hold |
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.18 #16100 +/- ##
================================================
- Coverage 80.89% 80.87% -0.03%
================================================
Files 210 210
Lines 16744 16760 +16
================================================
+ Hits 13545 13554 +9
- Misses 2847 2857 +10
+ Partials 352 349 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
elijah-rou
referenced
this pull request
in CerebriumAI/kserving
Nov 17, 2025
* adjust revisionfailure test image to allow changing the state of the pod * include test to ensure min-scale transition works as expected a previous revision should scale down when only the next revision is ready * fix linter warnings * fix revision conditions when initial scale isn't achieved * give more time for the pods to be running * log pod states when it fails * ensure new revision becomes ready and holds scale while old revision is scaled down --------- Co-authored-by: Dave Protasowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #16094