Skip to content

Add distinct logging for timeout types #16109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 4 commits into from
Oct 7, 2025
Merged

Add distinct logging for timeout types #16109

knative-prow merged 4 commits into from
Oct 7, 2025

Conversation

@thiagomedina
Copy link
Member

@thiagomedina thiagomedina commented Oct 4, 2025 •
edited
Loading

Fixes #15752

Proposed Changes

  • Add distinct logging for each timeout type

Release Note

@knative-prow knative-prow bot requested review from dsimansk and skonto October 4, 2025 19:34
@knative-prow
Copy link

knative-prow bot commented Oct 4, 2025

Welcome @thiagomedina! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 4, 2025

Hi @thiagomedina. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

dprotaso commented Oct 6, 2025

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.05%. Comparing base (561f348) to head (ceb6b42).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/http/handler/timeout.go 80.00% 1 Missing ⚠️
pkg/queue/sharedmain/handlers.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16109      +/-   ##
==========================================
- Coverage   80.07%   80.05%   -0.03%     
==========================================
  Files         214      214              
  Lines       16907    16920      +13     
==========================================
+ Hits        13538    13545       +7     
- Misses       3013     3016       +3     
- Partials      356      359       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dprotaso
dprotaso reviewed Oct 6, 2025
View reviewed changes
vendor/knative.dev/pkg/network/error_handler.go Outdated

func ErrorHandler(logger *zap.SugaredLogger) func(http.ResponseWriter, *http.Request, error) {
return func(w http.ResponseWriter, req *http.Request, err error) {
if errors.Is(err, context.Canceled) {
Copy link
Member

@dprotaso dprotaso Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would be done: https://github.com/knative/pkg

Copy link
Member Author

@thiagomedina thiagomedina Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, now I got it
sorry for the misunderstanding, I've opened the PR
knative/pkg#3268

pkg/http/handler/timeout_test.go Outdated
body: scenario.timeoutMessage,
timeoutFunc: StaticTimeoutFunc(scenario.timeout, scenario.responseStartTimeout, scenario.idleTimeout),
clock: fakeClock,
logger: zap.NewNop().Sugar(),
Copy link
Member

@dprotaso dprotaso Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a zap test logger? https://pkg.go.dev/go.uber.org/zap/zaptest#NewLogger

Copy link
Member Author

@thiagomedina thiagomedina Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I changed it

@dprotaso
Copy link
Member

dprotaso commented Oct 7, 2025

/lgtm
/approve

thanks @thiagomedina for the change.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, thiagomedina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@knative-prow knative-prow bot merged commit 4ce8c6e into knative:main Oct 7, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso dprotaso left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

@skonto skonto Awaiting requested review from skonto

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Human readable logging on timeout

2 participants

@thiagomedina @dprotaso