Skip to content

Istio now handles PreStop hooks correctly so we can drop our workaround #16164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Nov 27, 2025
Merged

Istio now handles PreStop hooks correctly so we can drop our workaround #16164

knative-prow merged 1 commit into from
Nov 27, 2025

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 16, 2025 •
edited
Loading

Related to #16163

Previously we had a workaround in our serverless service in order to allow our prestop hook to work when Istio Mesh was enabled.

This isn't needed anymore since Istio 1.25 see: istio/istio@0e30509

@knative-prow
Copy link

knative-prow bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto October 16, 2025 17:41
@dprotaso dprotaso changed the title Istio now handles prestop hooks correctly so we can drop our workaround [wip] Istio now handles prestop hooks correctly so we can drop our workaround Oct 16, 2025
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@dprotaso dprotaso force-pushed the drop-exposing-draining-port branch from 2f8062e to b925d6c Compare October 16, 2025 17:48
@dprotaso dprotaso force-pushed the drop-exposing-draining-port branch from b925d6c to 08dc2b2 Compare October 16, 2025 17:56
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.03%. Comparing base (cf48bab) to head (08dc2b2).
⚠️ Report is 63 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16164      +/-   ##
==========================================
- Coverage   80.06%   80.03%   -0.03%     
==========================================
  Files         214      214              
  Lines       16943    16931      -12     
==========================================
- Hits        13565    13551      -14     
- Misses       3017     3022       +5     
+ Partials      361      358       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member Author

dprotaso commented Nov 3, 2025

/test all

@dprotaso dprotaso changed the title [wip] Istio now handles prestop hooks correctly so we can drop our workaround Istio now handles prestop hooks correctly so we can drop our workaround Nov 3, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Nov 3, 2025

/assign @nader-ziada @linkvt @Fedosin

@dprotaso dprotaso changed the title Istio now handles prestop hooks correctly so we can drop our workaround Istio now handles PreStop hooks correctly so we can drop our workaround Nov 3, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Nov 3, 2025

/test ?

@knative-prow
Copy link

knative-prow bot commented Nov 3, 2025

@dprotaso: The following commands are available to trigger required jobs:

/test build-tests

/test contour-latest

/test contour-tls

/test gateway-api-latest

/test istio-latest-no-mesh

/test istio-latest-no-mesh-tls

/test kourier-stable

/test kourier-stable-tls

/test unit-tests

/test upgrade-tests

The following commands are available to trigger optional jobs:

/test gateway-api-latest-and-contour

/test https

/test istio-latest-mesh

/test istio-latest-mesh-short

/test istio-latest-mesh-tls

/test performance-tests

Use /test all to run the following jobs that were automatically triggered:

build-tests_serving_main

istio-latest-no-mesh-tls_serving_main

istio-latest-no-mesh_serving_main

unit-tests_serving_main

upgrade-tests_serving_main
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member Author

dprotaso commented Nov 3, 2025

/test istio-latest-mesh

1 similar comment
@dprotaso
Copy link
Member Author

dprotaso commented Nov 4, 2025

/test istio-latest-mesh

@dprotaso
Copy link
Member Author

dprotaso commented Nov 4, 2025

Failure doesn't seem related to the PreStop Hook - given I'd expect way more failures if that didn't work

@dprotaso
Copy link
Member Author

dprotaso commented Nov 4, 2025

/hold

maybe not

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Nov 4, 2025

/test istio-latest-mesh

@dprotaso
Copy link
Member Author

dprotaso commented Nov 4, 2025

Ok - maybe it is a flake the test passed but a different failed. Seems like the GKE cluster api server went down

/test istio-latest-mesh

@dprotaso
Copy link
Member Author

dprotaso commented Nov 26, 2025

/test istio-latest-mesh

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Nov 26, 2025

/assign @linkvt @nader-ziada

@dprotaso
Copy link
Member Author

dprotaso commented Nov 26, 2025

I think this change is good and if it flakes in CI we can reverse it easily

@linkvt
Copy link
Contributor

linkvt commented Nov 27, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@knative-prow knative-prow bot merged commit 753a910 into knative:main Nov 27, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@skonto skonto Awaiting requested review from skonto

Assignees

@linkvt linkvt

@nader-ziada nader-ziada

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @linkvt @nader-ziada @Fedosin