Skip to content

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #16141

…e condition

setting the annotation before creating the PA eliminating the race condition
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.16%. Comparing base (d11fb31) to head (681fcfd).
⚠️ Report is 2 commits behind head on release-1.19.

Files with missing lines Patch % Lines
pkg/reconciler/revision/cruds.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.19   #16191      +/-   ##
================================================
+ Coverage         80.09%   80.16%   +0.06%     
================================================
  Files               214      214              
  Lines             16909    16920      +11     
================================================
+ Hits              13544    13564      +20     
+ Misses             3004     2998       -6     
+ Partials            361      358       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nader-ziada
Copy link
Member

/retest

@dprotaso
Copy link
Member

blocked on #16192

@dprotaso
Copy link
Member

/retest

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@nader-ziada
Copy link
Member

/retest

Error: init failed to get project from boskos: failed to get a "gke-project" from boskos: resources not found

@dprotaso
Copy link
Member

/retest

@knative-prow knative-prow bot merged commit e73536d into knative:release-1.19 Oct 22, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants