-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[release-1.19] Fix: PodAutoscaler not reconciled due to missing class annotation #16191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.19] Fix: PodAutoscaler not reconciled due to missing class annotation #16191
Conversation
…e condition setting the annotation before creating the PA eliminating the race condition
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #16191 +/- ##
================================================
+ Coverage 80.09% 80.16% +0.06%
================================================
Files 214 214
Lines 16909 16920 +11
================================================
+ Hits 13544 13564 +20
+ Misses 3004 2998 -6
+ Partials 361 358 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
blocked on #16192 |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest
|
|
/retest |
This is an automated cherry-pick of #16141