Fixes OpenAL default microphone selection #2339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkast
pushed a commit
that referenced
this pull request
Jun 3, 2025
Thanks @squarebananas for spotting this bug. For the record, the list will contain a non-mic device but we can't do something about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OpenAL default microphone selection.
The
OpenAL.ALC.alcGetStringmethod (also referred to in another library here https://learn.microsoft.com/en-us/dotnet/api/opentk.audio.openal.alcgetstringlist) can either give:IntPtr.Zero)Currently the initialized output device is used with this method, and this results in no microphone being captured. Switching to
IntPtr.Zeroresolves this as it provides the correct list used to populate the available Microphone list, which is then used to select a default Microphone.