serialport: Disable udev dependency #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects only Linux and "won't expose as much information and may return ports that don't exist physically", but serialport does still obtain VID/PID and serial number (which are what this crate looks into), and the nonexisting devices should not affect USB either.
Merged
|
LGTM - I wanted to remove libusb from the exercise code too, using nusb. |
chrysn
added a commit
to chrysn-pull-requests/nrfdfu-rs
that referenced
this pull request
May 21, 2025
Those have not been needed since [27]. [27]: knurling-rs#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects only Linux and "won't expose as much information and may return ports that don't exist physically", but it does expose VID/PID and serial number, and the nonexisting devices should not affect USB either.
The reason to do this is to cut build dependencies. (The underlying effort in serialport was done for probe-rs for the benefit of not pulling libudev as a build dependency in there).
In theory this might speed up builds, but my timings vary too much to say whether the speedup is significant.