Skip to content

#1297 Allow to exclude fields from generated GraphQL objects #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 9, 2023
Merged

#1297 Allow to exclude fields from generated GraphQL objects #1299

merged 4 commits into from
Aug 9, 2023

Conversation

sabirove
Copy link
Contributor

@sabirove sabirove commented Aug 7, 2023


Description

Related to #1297


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 7, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@sabirove
Copy link
Contributor Author

sabirove commented Aug 7, 2023

Hey @kobylynskyi , @jxnu-liguobin , the build seems to be broken.

* What went wrong:
A problem occurred configuring root project 'graphql-java-codegen'.
> Could not resolve all files for configuration ':classpath'.
   > Could not resolve org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:4.3.0.3225.
     Required by:
         project : > org.sonarqube:org.sonarqube.gradle.plugin:4.3.0.3225
      > No matching variant of org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:4.3.0.3225 was found. The consumer was configured to find a library for use during runtime, compatible with Java 8, packaged as a jar, and its dependencies declared externally, as well as attribute 'org.gradle.plugin.api-version' with value '8.0.2' but:
          - Variant 'apiElements' capability org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:4.3.0.3225 declares a library, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component for use during compile-time, compatible with Java 11 and the consumer needed a component for use during runtime, compatible with Java 8
              - Other compatible attribute:
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0.2')
          - Variant 'javadocElements' capability org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:4.3.0.3[22](https://github.com/kobylynskyi/graphql-java-codegen/actions/runs/5781556112/job/15666845991?pr=1299#step:7:23)5 declares a component for use during runtime, and its dependencies declared externally:
              - Incompatible because this component declares documentation and the consumer needed a library
              - Other compatible attributes:
                  - Doesn't say anything about its target Java version (required compatibility with Java 8)
                  - Doesn't say anything about its elements (required them packaged as a jar)
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0.2')
          - Variant 'runtimeElements' capability org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:4.3.0.32[25](https://github.com/kobylynskyi/graphql-java-codegen/actions/runs/5781556112/job/15666845991?pr=1299#step:7:26) declares a library for use during runtime, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component, compatible with Java 11 and the consumer needed a component, compatible with Java 8
              - Other compatible attribute:
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0.2')
          - Variant 'sourcesElements' capability org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:4.3.0.3225 declares a component for use during runtime, and its dependencies declared externally:
              - Incompatible because this component declares documentation and the consumer needed a library
              - Other compatible attributes:
                  - Doesn't say anything about its target Java version (required compatibility with Java 8)
                  - Doesn't say anything about its elements (required them packaged as a jar)
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0.2')

Any ideas how to fix this?

@jxnu-liguobin
Copy link
Collaborator

My PR is the same, I'm not sure what happened 🥲

Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabirove, looks good. But please add your new property to:


(and MappingConfigTest as well)

@sabirove sabirove requested a review from kobylynskyi August 9, 2023 04:15
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Will include this change in the next release. Stay tuned.

@kobylynskyi kobylynskyi merged commit ac08c75 into kobylynskyi:main Aug 9, 2023
@kobylynskyi kobylynskyi added this to the 5.8.1 milestone Aug 9, 2023
@yeikel
Copy link
Contributor

yeikel commented Aug 15, 2023

@kobylynskyi When is the release planned?

@kobylynskyi kobylynskyi modified the milestones: 5.8.1, 5.9.0 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants