Improve and modernize Octree.swift #2044
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
邮件已收到。我会尽快回复！祝您一切顺利！兰雨田
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Corrected, refined and improved by Marco Binder (Heidelberg, Germany), 2025
using ChatGPT as a coding buddy. BUG FIXES: bug removed in tryAdd, where it was
implicitly expected that elements is never nil (which it was upon subdivision).
REFINEMENTS: improved efficiency in Box .contains(simd3_double), including using
an epsilon to prevent unneccessary subdivision upon rounding errors; several
other steps refined. IMPROVEMENTS: tree now autocollapses upon removing elements,
turning empty leafs into internal nodes again; accepts elements with box-regions
instead of point positions, similar to the Apple GKOctree implementation; now
respects minimumCellSize from initializer, saves it and subdivides only until
reaching minimum size, after which it bulks elements in single leave.