Building pvr.nextpvr-21.3.2-Omega release on Arch Linux fails with CMake < 3.5 compatibility error

[wmarler]

Ages ago I created an Arch Linux package of this plugin on the AUR. I didn't really think anyone was using it, I stopped keeping up with it, and it was marked outdated today. I went to fix it and found that I can't build it.

I am using the 21.3.2-Omega release b/c on Arch, Kodi is version 21 (21.2-9).

My cmake completes successfully:

/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build% cmake -Wno-dev -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DADDONS_TO_BUILD=pvr.nextpvr -DPACKAGE_ZIP=1 ../../xbmc-21.0-Omega/cmake/addons
-- Addon source tarball caching is enabled
-- ZIP packaging enabled (destination: /tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build/build/zips)
-- Building following addons: pvr.nextpvr
cmake -E touch: failed to update "/usr/lib/kodi/.cmake-inst-test".
cmake -E touch: failed to update "/usr/share/kodi/.cmake-inst-test".
-- check_install_permissions /usr: failed to create files
-- NEED_SUDO: TRUE (no write permission for /usr)
-- 
-- ---- Preparing general dependencies ----
-- No platform specific file /tmp/makepkg/kodi-addon-pvr-nextpvr/src/xbmc-21.0-Omega/cmake/addons/depends/linux/CMakeLists.txt found
-- Exclusion list: 
-- Exact Match list: pvr.nextpvr
-- Regex list: 
-- Exact match pvr.nextpvr, building addon
-- 
-- ---- Configuring addon /tmp/makepkg/kodi-addon-pvr-nextpvr/src/xbmc-21.0-Omega/cmake/addons/addons/pvr.nextpvr/pvr.nextpvr.txt ----
-- pvr.nextpvr: git branch/tag Omega resolved to hash: fd66eb66091059c52de0954da09040375e0b98cc
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/.github/
...
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/src/utilities/GenreMapper.h
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/src/utilities/SettingsMigration.cpp
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/src/utilities/SettingsMigration.h
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/src/utilities/XMLUtils.h
-- Processing /tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build/build/pvr.nextpvr/depends/common/tinyxml2/tinyxml2.txt
-- tinyxml2 url: https://github.com/leethomason/tinyxml2/archive/7.1.0.tar.gz
-- pvr.nextpvr DEPENDENCIES: tinyxml2
-- 
CMake Warning at CMakeLists.txt:505 (message):
  sudo rights needed to install to /usr


-- 
please type "make sudo-install"


-- Configuring done (0.4s)
-- Generating done (0.0s)
-- Build files have been written to: /tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build

However when I go to make I get an error that Compatibility with CMake < 3.5 has been removed from CMake.:

/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build% make
[  5%] Creating directories for 'tinyxml2'
[ 11%] Performing download step (download, verify and extract) for 'tinyxml2'
-- Downloading...
   dst='/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build/build/download/7.1.0.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='https://github.com/leethomason/tinyxml2/archive/7.1.0.tar.gz'
-- verifying file...
       file='/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build/build/download/7.1.0.tar.gz'
-- Downloading... done
-- extracting...
     src='/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build/build/download/7.1.0.tar.gz'
     dst='/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build/build/tinyxml2/src/tinyxml2'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[ 17%] No update step for 'tinyxml2'
[ 23%] Performing patch step for 'tinyxml2'
[ 29%] Performing configure step for 'tinyxml2'
CMake Warning:
  Ignoring extra path from command line:

   "/usr"


CMake Warning:
  Ignoring extra path from command line:

   "/usr"


CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!
make[2]: *** [CMakeFiles/tinyxml2.dir/build.make:92: build/tinyxml2/src/tinyxml2-stamp/tinyxml2-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:181: CMakeFiles/tinyxml2.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

I think this is because the Omega branch is still using tinyxml7.1, which has a very old cmake_minimum_required(VERSION 2.6 FATAL_ERROR) in its CMakeLists.txt .

/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega% grep cmake_minimum_required ./build/build/tinyxml2/src/tinyxml2/CMakeLists.txt                      
cmake_minimum_required(VERSION 2.6 FATAL_ERROR)

In the Piers branch you've updated to using tinyxml2-9.0.0 -- can the Omega branch be similarly updated?

I tried to test this to see if it would work, but I'm missing something with cmake -- Even though I modify the files in depends/common/tinyxml2 to use the 9.0.0 archive, when I run cmake it looks for git and uses the latest Omega branch, ignoring my local changes:

/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build% ls ../depends/common/tinyxml2 
flags.txt  tinyxml2.sha256  tinyxml2.txt

/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build% md5sum ../depends/common/tinyxml2/*
f42952a707f1fe5eeddead956f0f1497  ../depends/common/tinyxml2/flags.txt
2a2279adec71b1659a9b47f773a5f37a  ../depends/common/tinyxml2/tinyxml2.sha256
1ddccc1cb11872a7570678ee09111680  ../depends/common/tinyxml2/tinyxml2.txt

/tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build% cmake -Wno-dev -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Debug -DADDONS_TO_BUILD=pvr.nextpvr -DPACKAGE_ZIP=1 ../../xbmc-21.0-Omega/cmake/addons
-- The C compiler identification is GNU 14.2.1
-- The CXX compiler identification is GNU 14.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
...
-- Exact match pvr.nextpvr, building addon
-- 
-- ---- Configuring addon /tmp/makepkg/kodi-addon-pvr-nextpvr/src/xbmc-21.0-Omega/cmake/addons/addons/pvr.nextpvr/pvr.nextpvr.txt ----
-- Found Git: /usr/bin/git (found version "2.49.0")
-- pvr.nextpvr: git branch/tag Omega resolved to hash: fd66eb66091059c52de0954da09040375e0b98cc
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/.github/

...
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/src/utilities/SettingsMigration.h
x pvr.nextpvr-fd66eb66091059c52de0954da09040375e0b98cc/src/utilities/XMLUtils.h
-- Processing /tmp/makepkg/kodi-addon-pvr-nextpvr/src/pvr.nextpvr-21.3.2-Omega/build/build/pvr.nextpvr/depends/common/tinyxml2/tinyxml2.txt
-- tinyxml2 url: https://github.com/leethomason/tinyxml2/archive/7.1.0.tar.gz
-- pvr.nextpvr DEPENDENCIES: tinyxml2
...

[emveepee]

Personally I don't make structural changes this late in development especially when I won't run Omega anymore. If you want you can create the PR and I leave it to @ksooo and @phunkyfish to approve assuming you fully test it.

For your issue, when building did you remove depends/common/tinyxml2/CMakeLists.txt before the first cmake? Seems to build here when I did that.

Looking at that file I also so see

cmake_minimum_required(VERSION 2.6 FATAL_ERROR)

Did you try changing that to 3.5 as they suggested to see if this is causing the issue. I am not sure what Kodi cmake minium is. I can see a PR changing this to the Kodi minimum safely in Omega.

[fuzzard]

It's nothing to do with Kodi. I'm sure if more info was provided you would find you are now using cmake 4.0. of which has this major breaking change

https://cmake.org/cmake/help/latest/release/4.0.html#id13

The best I could suggest is using https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html#variable:CMAKE_POLICY_VERSION_MINIMUM in some manner to override the policy version. I've not looked at an external build of add-ons for how best to achieve this at all however, so you are in uncharted waters

[phunkyfish]

Updating tinyxml from v1 to v2 is a substantial change and is not going to be possible in Omega.

[wmarler]

I'm sure if more info was provided you would find you are now using cmake 4.0. of which has this major breaking change

This is correct, Arch is now up to cmake 4.0, and that's what I'm using.

For your issue, when building did you remove depends/common/tinyxml2/CMakeLists.txt before the first cmake? Seems to build here when I did that.

Yea ... I actually modified the contents of the depends/common/tinyxml2 dir to match what's in the Piers branch. But when I invoke cmake it doesn't use my local changes, it pulls down the release from git:

-- ---- Configuring addon /tmp/makepkg/kodi-addon-pvr-nextpvr/src/xbmc-21.0-Omega/cmake/addons/addons/pvr.nextpvr/pvr.nextpvr.txt ----
-- Found Git: /usr/bin/git (found version "2.49.0")
-- pvr.nextpvr: git branch/tag Omega resolved to hash: fd66eb66091059c52de0954da09040375e0b98cc

I don't know how to tell cmake not to do that. I was hoping that bumping the version of tinyxml2 from 7.1 (released August , 2019) to something newer (e.g. tinyxml2 9.0.0, released June 2021) would be good enough ... though I just looked in tinyxml2's releases and even in the 11.0.0 release their CMakeLists.txt has cmake_minimum_required(VERSION 3.15) ... which iiuc cmake 4 will complain about.

[fuzzard]

No it won't complain. The removed version support is < 3.5

[wmarler]

No it won't complain. The removed version support is < 3.5

I guess I don't understand cmake's error then. I thought cmake 4 was saying "hey, you've got cmake_minimum_required(VERSION 3.15) specified, but you need to have cmake_minimum_required(VERSION 3.5), or you need to specify a range, e.g. cmake_minimum_required(VERSION 3.5...4.0)"

I was trying to test that, but I can't get cmake to use my locally changed files, it goes out and fetches the Omega branch from git. I'm not at all familiar with cmake, unfortunately ... Do you know of a flag or something that I can invoke to tell cmake not to go out and fetch from git?

[phunkyfish]

It’s a different addon but you should be able to modify easily for next pvr.

You need to specify a local source dir, otherwise it will put from git

https://github.com/kodi-pvr/pvr.vuplus?tab=readme-ov-file#linux

[phunkyfish]

Oh, there is one for nextpvr too

https://github.com/kodi-pvr/pvr.nextpvr

It’s the DCMAKE_INSTALL_PREFIX that you need to point to your local source.

[emveepee]

Updating tinyxml from v1 to v2 is a substantial change and is not going to be possible in Omega.

@phunkyfish this isn't that drastic he wants an updated version on tinyxml2 but I am not willing to test it even if it probably doesn't break things.

I tried earlier this week to build Kodi on Windows with cmake 4 and couldn't build it and gave up. However I just tried cmake 4.0.1 with pvr.nextpvr Omega on Linux and get the same message as @wmarler.

Changing https://github.com/kodi-pvr/pvr.nextpvr/blob/Omega/depends/common/tinyxml2/CMakeLists.txt#L1 and https://github.com/kodi-pvr/pvr.nextpvr/blob/Omega/depends/common/tinyxml2/CMakeLists.txt#L2 to 3.5 workd got me though.

[wmarler]

Oh, there is one for nextpvr too

https://github.com/kodi-pvr/pvr.nextpvr

... uh that's where we are ...

It’s the DCMAKE_INSTALL_PREFIX that you need to point to your local source.

this flag controls where built binaries get copied to when someone runs make install. It doesn't stop cmake from going out and fetching ...

Changing https://github.com/kodi-pvr/pvr.nextpvr/blob/Omega/depends/common/tinyxml2/CMakeLists.txt#L1 and https://github.com/kodi-pvr/pvr.nextpvr/blob/Omega/depends/common/tinyxml2/CMakeLists.txt#L2 to 3.5 workd got me though.

Ok, so having read this I decided to build according to the README.md and I got it to build as well. I guess what I was seeing with cmake ignoring my locally changed files was something I was doing wrong with the Arch packaging process.

[emveepee]

I guess for compatibility I could use this change to use the Kodi Omega default if you need to pull from the source.

if (CMAKE_MAJOR_VERSION VERSION_LESS "4")
  cmake_minimum_required(VERSION 3.12)
else()
  cmake_minimum_required(VERSION 3.5)
  cmake_policy(VERSION 3.5)
endif()

[phunkyfish]

Ok, so I guess we can close this issue

[fuzzard]

I guess for compatibility I could use this change to use the Kodi Omega default if you need to pull from the source.

if (CMAKE_MAJOR_VERSION VERSION_LESS "4")
  cmake_minimum_required(VERSION 3.12)
else()
  cmake_minimum_required(VERSION 3.5)
  cmake_policy(VERSION 3.5)
endif()

Totally unnecessary with current cmske 4.0.
3.5 is accepted with cmake 4.0, but more importantly if you are going to say 3.12 is the base for "some" case, just make it the base for all

[emveepee]

Totally unnecessary with current cmske 4.0. 3.5 is accepted with cmake 4.0, but more importantly if you are going to say 3.12 is the base for "some" case, just make it the base for all

I wasn't thinking I could just make it 3.5 to match the master file

pvr.nextpvr/CMakeLists.txt

Line 2 in 8319a0c

project(pvr.nextpvr)

I am not sure what profile to use for cmake 4 in Omega or for Piers though. Is the default acceptable when using cmake 4?