Limit warning message logging frequency in TimeKeeper #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for the PR. But, I think we should not suppress these warnings because they are quite critical and the user should not ignore them. |
Contributor
Author
|
You're right. It's just a little bit annoying that the log files get drowned by these messages caused by NTP time sync in a long running process. Let me close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no logging rate limit in
TimeKeeper, which means warning messages for IMU timestamp rewind and LiDAR IMU time diff will be printed at the same rate of the IMU.In this PR, I limited these type of messages to be printed only once per second, to avoid flooding the terminal and logging files.