Skip to content

[IndexedDB/KATC] Implement or partially implement parsing for BigInts, Strings, arrays containing data other than strings and objects, and others #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 6, 2025
Merged

[IndexedDB/KATC] Implement or partially implement parsing for BigInts, Strings, arrays containing data other than strings and objects, and others #2144

merged 7 commits into from
Mar 6, 2025

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Mar 6, 2025 •
edited
Loading

Relates to #2055

  • Partially implement BigInt (this got annoying -- plus I can't seed the firefox database with data if it includes BigInts for some reason, so I can't even test the firefox implementation -- so I gave up on it and returned stubbed data)
  • Fill in a bunch of other missing data types and return a specific error when we encounter them during parsing, so we'll know quickly which data type we need to implement
  • Implemented String for Chrome
  • Allow parsing arrays with data in them besides strings and objects
  • Make the test script that generates the test databases more useful

@RebeccaMahany RebeccaMahany added the features-improvements Features and Improvements label Mar 6, 2025
@RebeccaMahany RebeccaMahany changed the title [IndexedDB/KATC] [IndexedDB/KATC] Implement or partially implement parsing for BigInts, Strings, arrays containing data other than strings and objects, and others Mar 6, 2025
@RebeccaMahany RebeccaMahany marked this pull request as ready for review March 6, 2025 18:55
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Mar 6, 2025
Merged via the queue into kolide:main with commit 3ae3e26 Mar 6, 2025
33 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/indexeddb-stubs branch March 6, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

Assignees
No one assigned
Labels
features-improvements Features and Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @zackattack01